[quote=“cloaked-ghost, post:8, topic:729”]Great work so far, Dohavocom! I’ve been taking notes when playing. Here’s the bugs I’ve found so far in addition to the ones already mentioned:
Significant
[ul][li]Body Lab → “Do you need any of these ingredients” → King’s Sorrel – Handing over the herbs doesn’t actually subtract the herbs from the proxy’s inventory.[/li]
[li]Body Lab → Mental Potions will get you stuck in an endless loop if you don’t have enough ingredients[/li]
[li]Hospital → Body Shape Modification → Watermelon Special – If a proxy knows about the watermelon special, but does not have enough breast milk in her inventory, then clicking the “watermelon special” link will activate your mod’s file, giving the proxy a breast fetish and increasing her desire for fat.[/li]
[li](Not 100% sure of repro) The conditions for city/icecream_shop/main and city/icecream_shop/main_huge seem to be bugged. They’re currently (clock.getHours() >= 10) || (clock.getHours() <= 22), which is always true, so the player usually cannot see the night scene. Changing the condition to (clock.getHours() >= 10) && (clock.getHours() <= 22) fixes this.[/li]
[li]Given the way you’ve structured the conditionals for the status_fat_* includes, Myre often won’t display any status message (just a blank space) when her belly is between 10% and 50% full.[/li][/ul]
Regarding the feeding system, I think it’s a great start, but I noticed that if you use the buffs provided by rubbing a proxy’s belly & encouraging them, and then stuff them until they’re below “happy”, then they’ll almost always quit one turn after the feeding session ends due to being extremely overfull when the buffs expire. It’s kind of jarring.
Also, you can chain-rub a proxy’s belly with no consequences (no time cost, no mood/energy cost) in order to boost their desire for fat to sky-high levels in one session.
(It’s kind of a pity that the core FM system doesn’t really let you easily implement some kind of system that resists too-fast changes like that.)
Minor/Cosmetic
[ul][li]pork_raw has the same consumption message as the strength potion; raw_pork has no consumption message at all.[/li]
[li]templates/char/myre/goal_thought_3b seems to have a copypaste error, as it includes the same action description of status_fat_3.[/li]
[li]templates/char/myre/goal_thought_7 also seems to have a copypaste error, as it also is an action instead of a thought.[/li][/ul]
Purely Suggestion
When going through the mod’s files, I noticed you basically didn’t use the priority system at all, and you rarely nest includes. It might be a bit cleaner and simpler to code if you used cascading includes for the really big decision trees, like the status_ messages, since they need to include reactions for whether she’s very full, not so full, empty and whether or not the proxy is allowed to stuff her. If there’s a message that needs to override others, you can bump the priority up by one.
An example:
(theoretical "status_2" event)
Conditions:
PerGetFlag("myre_meet") ==1 && myre.getStat("generic.abdomen") >3 && myre.getStat("generic.abdomen") <=5;
Script:
<%Include("char/myre/status_2_");%>
("status_2_full" event, identical effect to current "status_full_2")
Conditions: myre.getStat("abdomen.food")>(0.5*myre.getStat("abdomen.stomach_volume"));
Script: (just the regular text)
("status_2_fat" event, identical effect to current "status_fat_2")
Conditions: myre.getStat("abdomen.food")<(0.1*myre.getStat("abdomen.stomach_volume"));
Script: (just the regular text)
("status_2_fat2" event, identical effect to current "status_fat2a")
Conditions: myre.getStat("abdomen.food")<(0.1*myre.getStat("abdomen.stomach_volume")) && PerGetFlag("proxy_allowed_feed") == 1 && Chance(30) ;
Script: (regular text)
("status_2_ready" event, identical effect to current "status_ready_2")
Conditions: Chance(50) && GetFlag("myre_stuffing_okay") ==1 && PerGetFlag("proxy_allowed_feed") ==1;
Script: (text + SetFlag, just as currently written)And examining the above, you can see the gap in conditions between being 10% and 50% full. :)[/quote]
Fixed the King’s sorrel one - Actually all the ingredients had this issue, but apparently i missed this one
Infinite loop is fixed. I had that menu set as the return point. I removed that and it seems to have fixed it.
I had noticed this before but i don’t normally do breast related stuff. I added all the conditions from the base event into mine and that should fix it.
I’ve been aware of this bug for some time. I had noticed it for a long time but it didn’t bother me much so i let it sit not sure of how to fix it. Turns out I’m retarded. This is now fixed
The status_fat_* includes were designed that way because I only wanted her to make the comments when she was actually pretty full. I’ll have to look into it a bit deeper.
the feeding/encouraging part was something that i tried but didn’t work out in both content and stats. I had assumed that effects with the same name wouldn’t stack but i was apparently wrong. I also wasn’t sure how to work in encouragements without getting too fanficy. Any comments on the content or dialogue?
I hadn’t considered the consequences of the feeding causing proxies to quit. though it does kind of make sense though in a way? Regardless I’ll take a look at it sometime because i also want to completely rework how stomach volume is calculated and when i do that i’ll have to give part of the feeding system another pass. The problem is that i tried to “hack in” the force feeding part. because in the game there is no already existing code for the proxy being uncomfortably full or something.
pork_raw is now deleted. I guess i made the file twice and the consume message has been removed from the other one. It shouldn’t even be consumable unless it’s cooked though.
You’re right about 3b. It has been copy pasted from somewhere else. I’m not sure what text i cactually had there previously. I’ll have to give it a little bit of thought haha.
I don’t see an issue with goal_thought_7. maybe you clicked goal action 7 by mistake?
As to the structure thing its a limit of the fact that I learn and implement as i go. For example the character of Julia from a couple previous releases existed as a way for me to play around with the include function and building characters (like vicky, that cow lady, and…that other cow lady). I only had to pay any attention to the priorities recently when they started messing with one of the files i needed to merge down. Though your criticism there is good it comes down to me finding the motivation to refactor the templates there. it’s within my ability it would just have to get the motivation to do so. I do generally nowadays try to divvy things up in that way. I’m trying to move more and more towards accurate and detailed descriptions of things (for example the recent changes i made to the belly play where it tells you how far the belly is from the ground) and part of that is using more includes to get finer varied details.
But anyway , I really appreciate the feedback!